indeedeng / indeedeng/iwf

WorkerOptions under config has to be all lower case

Open
#566 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
661
Forks
63
PR merge metrics
No merged PRs in 30d

Description

This is due to a bug in Golang yaml:
https://github.com/go-yaml/yaml/issues/923

As feedback from a community user:
Image

Note: we had a mistake to not adding yaml annotation, but even we added it, it still won't work well because all the fields under WorkerOptions are not annotated either.

So potential solutions:

  1. switch to a different yaml library that can work as expected like the cases in JSON
  2. duplicate the WorkerOptions from Temporal/Cadence SDK and add yaml annotation properly
  3. [less likely] ask temporal/cadence to add yaml annotations

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating WorkerOptions and the configuration decoding path; compare the YAML behavior with the JSON cases described in the issue and review go-yaml/yaml issue #923. Done means a maintainer-selected solution makes mixed-case fields under WorkerOptions load correctly, with coverage for the reported configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.