indeedeng / indeedeng/iwf-java-sdk
[Maybe] Unify error handling for waitForWorkflowCompletion and tryGettingWorkflowResults
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 17
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
Today the withWait api will throw client side exception with long poll timeout sub status . Because this is a 4xx error from server.
https://github.com/indeedeng/iwf-java-sdk/blob/3409ea77f0b0764f0dbe79670ecd48a0aff9609e/src/test/java/io/iworkflow/integ/WorkflowUncompletedTest.java#L44
However, tryGetting api will throw UncompletedException.
this inconsistency could be a bit confusing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced integ/WorkflowUncompletedTest.java test around line 44 and compare the withWait and tryGetting workflow-result entry points. Check how each reports an incomplete workflow, then clarify the intended common behavior with maintainers; done means the inconsistency is resolved and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100