imsky / imsky/pull-review

parseGithubURL doesn't account for Enterprise Github

Open
#98 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature
Dominant language
JavaScript
Stars
210
Forks
15
PR merge metrics
No merged PRs in 30d

Description

the method `parseGithubURL` in the file `/github/index.js` expect that the url can ONLY ever be from github.com. Possibly a ENV configuration could be added for the a specified domain?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in /github/index.js at parseGithubURL and inspect how GitHub.com URLs are recognized. Determine how a configured Enterprise GitHub domain should be supplied, then verify that both the standard and configured domains are accepted without breaking existing URL parsing.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.