imsky / imsky/holder

Could not set size lesser than certain value

Open
#223 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
5.8k
Forks
585
PR merge metrics
No merged PRs in 30d

Description

https://github.com/imsky/holder/blob/5d03b972f0082c6c640f8e9223ca897ebc24dd50/src/lib/index.js#L844

This code use image dimensions and `App.defaults.scale` which is not configurable for fontSize computing. https://github.com/imsky/holder/blob/5d03b972f0082c6c640f8e9223ca897ebc24dd50/src/lib/index.js#L660

Hence font size could not be lesser then some computed value. It would be great to set any font size.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/lib/index.js at the referenced lines around 660 and 844. Trace how image dimensions and App.defaults.scale are used when computing fontSize, then run the existing test suite to establish current behavior. Done means the font-size calculation permits values smaller than the current computed minimum, with relevant behavior covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.