imsky / imsky/holder

Using holder with <picture> element doesn't work ?

Open
#195 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
5.8k
Forks
585
PR merge metrics
No merged PRs in 30d

Description

Hi, not sure if it me doing something wrong or trying to do something that's not possible.

Using holder with just `` works great. But if i want to do something like below to select the img based on orientation, or use webp with jpeg has the fallback then holder.js doesn't seem to work. Is it possible to have holder.js working in these situations ?

```



an image

```

many thanks

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the problem with the provided markup and compare it with the working case. Start by tracing holder.js's image-element processing and determine whether picture/source elements are in scope. Done means the documented orientation or WebP fallback example receives a working placeholder, with behavior verified against the existing image case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.