imsky / imsky/holder

Running Holder.js triggers warning in Firefox:

Open
#188 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
5.8k
Forks
585
PR merge metrics
No merged PRs in 30d

Description

When using Holder.js (2.9.3) in my project, I get

> mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

in holder.js on line 2049:
`Buffer.prototype.__proto__ = Uint8Array.prototype`

This seems code you imported from somewhere else ("The buffer module from node.js, for the browser."). Maybe there is a fixed upstream version?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at holder.js line 2049 and trace the bundled browser buffer implementation referenced in the report. Check whether the upstream buffer module has a Firefox-safe version, then reproduce the warning in Firefox and verify the bundled code no longer emits it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.