impress / impress/impress.js

Re-enable testing with Safari and IE / Edge

Open
#666 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
38.2k
Forks
6.6k
PR merge metrics
No merged PRs in 30d

Description

With the use of iframes for all qunit tests, I had to turn off Safari and IE in karma.conf-sauce.js. I would expect they'll work fine if I'd just add some option somewhere to allow javascript from the parent window to access the iframe.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with karma.conf-sauce.js and the QUnit tests that now run through iframes. Investigate how Safari and IE/Edge handle parent-window access to those frames and identify the configuration option needed. Done means Sauce-based testing is enabled for Safari and IE/Edge without breaking the existing iframe test setup.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.