impactmakers / impactmakers/climatechoice
Button nested inside of link
- Dominant language
- JavaScript
- Stars
- 60
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Description
At the moment, there are a few instances of `` elements being inside of an `` tag. For example, the 'Learn how you can help' on the home page:
As this links to another section further down the page, semantically it could do with being just a link. The button styles could be moved to the link, and the appearance preserved.
A benefit of doing this would be fixing slightly unusual keyboard focus behaviour. Because there are two interactive elements - both the '` and the ``, you have to tab twice to get past the element. It would also be a better experience for screen reader users.
I'm new to this project and not yet in the slack, but I'd be happy to put together a PR if it's welcome! :)
Contributor guide
Research direction
Start by locating the home page implementation and the other instances where a button is nested inside a link. Replace the nested interactive elements with semantically appropriate links while preserving the button styling. Done means the links retain their appearance, require only one keyboard focus stop, and provide clearer screen reader behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100