immersive-web / immersive-web/webxr-webgpu-binding

Fix WebIDL error

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Bikeshed
Stars
87
Forks
8
PR merge metrics
No merged PRs in 30d

Description

from GHAction error log
This prevents updating gh-pages one.

[41](https://github.com/immersive-web/WebXR-WebGPU-Binding/actions/runs/21828933276/job/62981408526#step:3:663)
  $ pnpm add webidl2
  + webidl2 24.5.0
  Invalid Web IDL detected:
    Validation error at line 11, inside `interface XRGPUBinding -> operation createProjectionLayer -> argument init`:
      XRProjectionLayer createProjectionLayer(optional XRGPUProjectionLayerInit init);
                                                                                ^ Optional dictionary arguments must have a default value of `{}`.
    
    Validation error at line 12, inside `interface XRGPUBinding -> operation createQuadLayer -> argument init`:
      XRQuadLayer createQuadLayer(optional XRGPUQuadLayerInit init);
                                                              ^ Optional dictionary arguments must have a default value of `{}`.
    
    Validation error at line 13, inside `interface XRGPUBinding -> operation createCylinderLayer -> argument init`:
      XRCylinderLayer createCylinderLayer(optional XRGPUCylinderLayerInit init);
                                                                          ^ Optional dictionary arguments must have a default value of `{}`.
    
    Validation error at line 14, inside `interface XRGPUBinding -> operation createEquirectLayer -> argument init`:
      XREquirectLayer createEquirectLayer(optional XRGPUEquirectLayerInit init);
                                                                          ^ Optional dictionary arguments must have a default value of `{}`.
  ❌  Invalid Web IDL detected... please fix the issues above.
    
    Validation error at line 15, inside `interface XRGPUBinding -> operation createCubeLayer -> argument init`:
      XRCubeLayer createCubeLayer(optional XRGPUCubeLayerInit init);
                                                              ^ Optional dictionary arguments must have a default value of `{}`.
    
  Error: ❌  Invalid Web IDL detected... please fix the issues above.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the WebIDL definitions for the XRGPUBinding operations named in the GitHub Actions error: createProjectionLayer, createQuadLayer, createCylinderLayer, createEquirectLayer, and createCubeLayer. Check the validation with webidl2 and update each optional dictionary argument so the action no longer reports invalid Web IDL.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.