immersive-web / immersive-web/lighting-estimation
Consider removing `XRLightProbe.sphericalHarmonicsOrientation` and `XRReflectionProbe.orientation`
Nobody has claimed this yet.
- Dominant language
- Bikeshed
- Stars
- 40
- Forks
- 11
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 1
Description
The orientation of the platform specific API's lighting estimation may not match the XRSpace orientation. XRLightProbe.sphericalHarmonicsOrientation and XRReflectionProbe.orientation were included to avoid the cost of generating rotated versions of SH and cube maps.
Rather than storing the relative orientation, perhaps the UA should generate rotated variants aligned with the XRSpace of the viewer for global lighting estimation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the issue's discussion of XRLightProbe.sphericalHarmonicsOrientation, XRReflectionProbe.orientation, and XRSpace alignment; no file or test is named. Compare the proposed alternatives and determine the API direction and acceptance criteria with the maintainers. Done means an agreed specification change, not merely an implementation edit.
Written by the indexing model from the issue text.
Assessment
- Domain
- api
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100