immersive-web / immersive-web/lighting-estimation

Promises should not be returned by a function called on XRFrame

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Bikeshed
Stars
40
Forks
11
Avg merge
1d 6h
Merged PRs (30d)
1

Description

If we can consider the requesting of xr-global-light-estimation or xr-global-reflection features at the XRSession as a request to capture and generate the lighting estimation data, it should not be necessary to use promises in the functions called on XRFrame.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the proposed behavior for feature requests on XRSession and promise-returning functions called on XRFrame. The issue names no files or tests, so first clarify the API design and intended lifecycle for lighting-estimation data. Done means reaching agreement on the behavior and identifying the corresponding proposal changes and validation plan.

Written by the indexing model from the issue text.

Assessment

Domain
api, web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.