immersive-web / immersive-web/lighting-estimation

Refactor spec to be subscription based

Open
#11 2 comments 0 reactions 1 assignee View on GitHub

@kearwood is already working on this.

Since Aug 6, 2019.

Dominant language
Bikeshed
Stars
40
Forks
11
Avg merge
1d 6h
Merged PRs (30d)
1

Description

Feedback from the W3C F2F meeting and feedback on the initial PR is supporting the pattern of "subscribing" to values that change from frame to frame, rather than resolving a promise each frame. We should refactor XRFrame.getGlobalLightEstimate() and XRFrame.getGlobalReflectionProbe() to be subscription based. This should be cohesive with the subscription pattern proposed for XR hit testing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.