imazen / imazen/cropimage

ie7

Open
#2 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
14
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Hi, thanks so much for this great tool!

Unfortunately I have to support clients on ie7 but it doesn't appear to be working for me in ie7. I notice in CropImage.cs line 282 appends a comma at the end of the value appended to the stringbuilder. ie7 doesn't like a final comma at the end of the last item. However, even when I remove the last comma and build the solution, ie7 crashes when I try to define a crop area so I'm not sure how to fix.

btw I used the basic.aspx page as an example.

Thanks :)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with CropImage.cs around line 282 and use basic.aspx as the reproduction entry point. Reproduce the IE7 crash while defining a crop area, then investigate the generated client-side value and related browser behavior. Done means the crop area can be defined successfully in IE7 without a trailing comma issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.