imagej / imagej/imagej.github.io

Fix images wider than 100%, and use lightbox

Open
#188 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug enhancement style
Dominant language
JavaScript
Stars
30
Forks
203
Avg merge
1h 50m
Merged PRs (30d)
1

Description

It used to be that images were not allowed to be larger than 100% in width. They'd scale down as the page got narrower. Unfortunately, this had negative side effects inside tables, since `100%` means something different than "width of the main content pane" when inside a table cell.

We need to find a way to make images max 100% of the main content pane by default again. Here is an example page that looks bad now because of it:

https://imagej.net/scripting/how-to-use-the-javadoc

It would also be ideal to make such images linked to their full-resolution versions, which pop up using lightbox when clicked. The thumbnail include (slated to be reworked) currently does this I think; see #154 for related work to be done.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the example page at https://imagej.net/scripting/how-to-use-the-javadoc and the existing thumbnail include referenced in the issue. Review #154 for related lightbox work. Done means regular images stay within the main content pane without breaking table layouts and can open their full-resolution versions in a lightbox.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.