imagej / imagej/imagej-ops

CreateOutputFFTMethods requires a image creator that can take an ImgFactory

Open
#650 1 comment 0 reactions 1 assignee Claimed by @gselzer View on GitHub
bug
Dominant language
Java
Stars
94
Forks
44
PR merge metrics
No merged PRs in 30d

Description

As described in [this forum post](https://forum.image.sc/t/error-when-correlating-large-images-in-ops/75433?u=gselzer), `CreateOutputFFTMethods` will fail when it is asked to create a large image, as it always assumes that the image can be an `ArrayImg`.

We need an Op that can take an `ImgFactory` as a parameter, so that `CreateOutputFFTMethods` can decide whether to make a `CellImg` or an `ArrayImg`. Or, at least, we can delegate the `ImgFactory` choice to [`Util.getSuitableImgFactory`](https://github.com/imglib/imglib2/blob/078f5af1c64808227f4eff6e1bb73594e5f49588/src/main/java/net/imglib2/util/Util.java#L893). And then `CreateOutputFFTMethods` needs to call it.

(And we should also make this change in ImageJ-Ops2 :grin:)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.