Consider whether DoGSingleSigmas should be commutative
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 94
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
According to the Difference of Gaussians wikipedia page, the mathematical definition involves always subtracting the narrower variance from the less narrow one. So: dog(10, 5) is gauss(10) - gauss(5) and dog(5, 10) is the same. I.e.: the order does not matter.
Should we change the implementation of DoGSingleSigmas to behave this way?
We cannot change DoGVaryingSigmas or DefaultDoG because the gaussian ops in use there do not necessarily have directly comparable single variances.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the implementation of DoGSingleSigmas and compare its handling of the two sigma arguments with the stated Difference of Gaussians definition. Also inspect DoGVaryingSigmas and DefaultDoG to preserve the distinction described in the issue; done requires a project decision on whether single-sigma calls should produce the same result in either order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100