imagej / imagej/imagej-common

DefaultDatasetView::autoscale() is inefficient and broken

Open
#42 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
12
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Sequential calls to `DefaultDatasetView#autoscale()` end up repeatedly computing the overall min and max. It could compute once and use cached results. Also it uses overall min and max rather than channel min and max which may be broken. We should revisit autoscaling.

Migrated-From: http://trac.imagej.net/ticket/1216

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating DefaultDatasetView#autoscale() and trace how it computes the overall and channel min/max values. Confirm the desired behavior from the existing implementation and tests, then make repeated calls avoid redundant min/max computation and verify that scaling uses the appropriate channel values.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.