imagej / imagej/imagej-common

Should we consolidate SaveAsImage with SaveDataset

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Java
Stars
12
Forks
15
PR merge metrics
No merged PRs in 30d

Description

First of all, `SaveDataset` should be moved to imagej-plugins-commands.

Second, do we even want a `SaveDataset`? It should really be modified as is to use an appropriately styled `File` chooser for selecting an output destination, and do all the validation that we are already doing in `SaveAsImage`... so is `SaveAsImage` sufficient?

If so we may want to create a legacy menu entry for `File > Export > Image...` that calls `SaveAsImage`, if we want to be consistent with `File > Import`.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating SaveDataset and SaveAsImage, then review how SaveDataset is packaged and how SaveAsImage performs file choosing and validation. Compare the existing menu entries with File > Import and determine whether SaveAsImage can replace SaveDataset, including whether a legacy File > Export > Image... entry is needed. Done means the consolidation and menu behavior have a clear, agreed implementation plan.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
desktop
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.