iiitl / iiitl/PerOXO

Leave room via WebSocket

Open Beginner friendly
#4 0 comments 0 reactions 0 assignees View on GitHub
easy feature
Dominant language
Rust
Stars
0
Forks
6
PR merge metrics
No merged PRs in 30d

Description

JoinRoom is handled in the session's recv task, but LeaveRoom is never matched -- the variant exists in ChatMessage and in RouterMessage but there's no match arm for it in session.rs

The JoinRoom arm is handled at line 211 of session.rs, but LeaveRoom falls through to the Ok(_) => {} catch-all. Wiring it up is a few lines -- send RouterMessage::LeaveRoom the same way JoinRoom sends RouterMessage::JoinRoom

Contributor guide

Open the contributing guide

Research direction

Start in session.rs at the JoinRoom match arm around line 211 and compare it with the LeaveRoom variant in ChatMessage and RouterMessage. Wire LeaveRoom through the session's recv task so it sends RouterMessage::LeaveRoom rather than falling through the Ok(_) catch-all; done when leaving a room is routed like joining one.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.