Simplify `SHARE_CONSTRAINT_COMMODITY_{LO,UP}`
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 150
- Forks
- 178
- Avg merge
- 17h 32m
- Merged PRs (30d)
- 2
Description
As part of #930, this suggestion was implemented, but then removed again after it was found to lead to test failures.
Due to lack of time, the PR was merged without further experimentation, but it could be explored whether this (or a similar) simplification could be made.
At first blush, this would seem to have no functional implication but would improve the readability and maintainability of the GAMS code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading issue #930, the linked suggestion in issue #929, and the discussion in PR #930 that led to the change being removed. Then reproduce or inspect the test failures mentioned there. Done means determining whether a simpler GAMS constraint form can be used without functional impact or test failures.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100