iiasa / iiasa/message_ix

Check the existing historical GDP parameter first

Open
#574 2 comments 0 reactions 0 assignees View on GitHub
discuss macro
Dominant language
Jupyter Notebook
Stars
150
Forks
178
Avg merge
17h 32m
Merged PRs (30d)
2

Description

I find the line in `read_data() `below checks whether `gdp_calibrate ` (imported from external excel input files) has at least 2 periods before the model horizon.

https://github.com/iiasa/message_ix/blob/2045b07c13322ce0224ce809ca1c64c1e5f64398/message_ix/macro.py#L275-L286

But this can be also imported from `self.s.par("historical_activity", {"technology":"GDP"})`. So the condition can first check the parameter and, if so, import historical values directly. If not, then it can ask for external historical GDP inputs.

Contributor guide

Open the contributing guide

Research direction

Start in message_ix/macro.py at read_data(), especially lines 275-286, and inspect how historical_activity for technology GDP and external gdp_calibrate inputs are represented. Confirm the existing parameter is checked first, with external historical GDP input requested only when it is unavailable or insufficient; verify the surrounding model behavior after the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.