ietf-tools / ietf-tools/xml2rfc

HTML writer handles list spacing attribute poorly

Open
#613 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

html pdf
Dominant language
HTML
Stars
124
Forks
79
Avg merge
6h 30m
Merged PRs (30d)
3

Description

type_defect | by jennifer@painless-security.com


The HTML writer has a couple issues with the spacing attribute on the list elements.

  1. When spacing="normal" or is not specified, the normal CSS class is applied to the resulting HTML elements. As far as I can tell, there is no such class defined.
  2. When <ul> classes are nested, the spacing CSS styles of the outer elements are applied to all the inner elements. E.g., if a <ul spacing="normal"> is inside a <ul spacing="compact">, the inner element will become an HTML element like <ul class="compact normal"> (and similar for the list items).

Issue migrated from trac:613 at 2022-02-08 07:13:50 +0000

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named; start by tracing the HTML writer's handling of the list spacing attribute. Confirm the output for omitted or normal spacing and for nested lists, then verify that normal emits no undefined class and nested elements retain only their own spacing styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.