ie3-institute / ie3-institute/PowerSystemDataModel

Check whether `FactoryData` and subclasses can be eliminated

Open
#976 3 comments 0 reactions 1 assignee View on GitHub

@staudtMarius is already working on this.

Since Mar 13, 2024.

code quality
Dominant language
Java
Stars
26
Forks
7
Avg merge
2h 33m
Merged PRs (30d)
15

Description

As another successive issue of #969, there might be a way to eliminate FactoryData and all its subclasses (EntityData etc.) by creating AssetInputs and similar entities directly.
To make this work, the new constructors in the form of AssetInputEntityData(EntityData entityData, OperatorInput operator) (but of course adapted for AssetInputs) could be used to iteratively create Inputs from the simplest UniqueEntity to the desired input type.

A side effect of this would be that error messages would be easier to create, since there is no way of ensuring that a FactoryData also includes UUID and id.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.