idefix-code / idefix-code/benchmarks
replacing home-brewed script with `idfx digest`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Description
I learned in #27 that aa2cfe3b03fb01579a06f3638f4f5b7412f70ffd added a script to parse idefix logs into json. This sounds an awful lot like a tool I wrote several years ago, which is part of idefix-cli: idfx digest.
This tool is actually already needed to run the analysis part of particles benchmarks, I'm still maintaining it to this day and not planning to stop. Please use it, it's a much more robust implementation of read.py, it has documentation and continuous integration, and it's breaking my heart to see it going unused for the one problem it's here to solve.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating read.py and the analysis path used for particles benchmarks, then review how the current log-to-JSON parsing is invoked. Compare that workflow with idefix-cli's documented idfx digest command; done means the benchmark analysis uses idfx digest and the home-grown parser is no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- performance, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100