icipe-official / icipe-official/vectoratlas-software-code

Change review process to send emails to users with reviewer role

Open
#430 0 comments 0 reactions 1 assignee View on GitHub

@andykitch is already working on this.

Since Feb 10, 2023.

Dominant language
TypeScript
Stars
2
Forks
8
Avg merge
5d 4h
Merged PRs (30d)
11

Description

Currently, the upload, review or approve processes send emails to the REVIEWER_EMAIL_LIST env variable. This should be changed to get a list of users with the reviewer role from the db, and get their email addresses from the authService.getEmailFromUserId method before sending the email to the list.

AC's:

  • An email is sent to all users with the reviewer role when data is uploaded, or a dataset is reviewed or approved.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.