icgc-argo / icgc-argo/program-service
Switch to using Postgres TYPEs instead of VARCHARs
Open
@rtisma is already working on this.
Since May 16, 2019.
enhancement
medium
- Dominant language
- Java
- Stars
- 3
- Forks
- 0
- Avg merge
- 14h 34m
- Merged PRs (30d)
- 2
Description
Currently, using varchars to represent enums in postgres. Using enums results in better performance, minimises risk of accidentally misspelled text (type safety) and is just cleaner. This also causes conversion logic to be implemented at the application layer, instead of letting the middleware (jpa/hibernate) take care of it.
- flyway migration script
- updating entities to automatically do conversion
- tests
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.