icgc-argo / icgc-argo/program-service

Add custom handling of protobuf target conversion using Mapstruct SPI

Open
#41 0 comments 0 reactions 1 assignee View on GitHub

@rtisma is already working on this.

Since May 2, 2019.

Dominant language
Java
Stars
3
Forks
0
Avg merge
14h 34m
Merged PRs (30d)
2

Description

Background

  • SPI = Service Provided Interface
  • Mapstruct provides the interface to override the default naming strategy implementation used to extract info for mapping

Problem

  1. When the target is protobuf and all target fields must be mapped, there is an issue specifically with protobuf because there are fields such as mergeFrom, clearOneOf, which mapstruct labels as fluent setters and so looks to find the associated field, but doesnt find any.
  1. Also, becuase protobuf setter names use setCarList instead of setCars, inorder to be compatible with lombok, this needs to be overrided too

Solution

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.