icflorescu / icflorescu/mantine-datatable
table shadow ios bug
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 102
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Table shadows are incorrectly set in Safari on iOS.
iOS may scroll the container to a negative value.
To Reproduce
just check mobile safari on iphone
Expected behavior
the Y shadow on top should turn off if y <= 0
Screenshots
Desktop (please complete the following information):
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]
Smartphone (please complete the following information):
- Device: [e.g. iPhone15]
- OS: [e.g. iOS17.5]
- Browser [safari]
Additional context
It seems to be somewhere in the useDataTableInjectCssVariables hook -
function processScrolling() {
const newScrolledToTop = scrollTop === 0;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the useDataTableInjectCssVariables hook, especially processScrolling, then reproduce the behavior on mobile Safari using the linked scrollable example. Check how negative iOS scroll values affect the top Y shadow, and verify that the shadow is off when the effective position is at or below zero.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100