icflorescu / icflorescu/mantine-datatable

Selection column is non-zero

Open
#775 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
102
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Currently, the column does not occupy the minimum size required for the checkbox, but has a fixed size of 44px specified in the code.

To Reproduce
https://icflorescu.github.io/mantine-datatable/examples/records-selection/#disable-selection-of-certain-records
Even on the website, you can see that there is extra space on the right side of the column.

Expected behavior
The selection column only takes up the space of the checkbox itself.

Screenshots

Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the records-selection example linked in the issue and trace the selection column implementation to the fixed 44px size mentioned in the report. Adjust the column sizing so it only occupies the checkbox's required space, then verify the example has no unnecessary space to the right.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.