icflorescu / icflorescu/mantine-datatable
When I click around the header checkbox, onChange of allRecordsSelectionCheckboxProps is not working.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 102
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
if you just click on the checkbox itself, onChange of allRecordsSelectionCheckboxProps works.
Please notice on the red box .
but if you click outside of checkbox on header column , but in the cell which includes checkbox on header column,
onChange of allRecordsSelectionCheckboxProps is not working.
I clicked around the checkbox, but inside of cell.
checkbox is checked, but onChange is not triggered
Codebase how it is being used.
Expected behavior
onChange of allRecordsSelectionCheckboxProps has to be triggered though I click outside/around the checkbox of cell if I set selectionTrigger="cell"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the selectionTrigger="cell" behavior and the allRecordsSelectionCheckboxProps onChange callback described in the issue. Reproduce the bug by clicking around the header checkbox within its cell, then compare the callback behavior with a direct checkbox click. Done means clicks in the surrounding header-cell area trigger onChange consistently, with a regression test covering both interactions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100