icflorescu / icflorescu/mantine-datatable
[Enhancement] Row expansion indication
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 102
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
When using the rowExpansion props, it is not always clear that a row can be expanded (or is clickable for expansion etc).
Describe the solution you'd like
A new prop added to the rowExpansion methods to allow for an indicator (i.e. chevron right for closed and chevron down for expanded/open). Icons should be provided by the user, as not everyone uses the same icon libraries so this would be deemed as required props when rowExpansion.indicators = true for instance.
Describe alternatives you've considered
A pseudo column that calculates which row(s) are expanded already. See this gist: https://gist.github.com/mikkurogue/b5add794faa2933e2a644959ca77524b
Additional context
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the rowExpansion props and current expanded-row rendering in the repository, then review the linked gist for the proposed pseudo-column alternative. Done means callers can opt into closed and expanded indicators, provide their own icons when enabled, and the indicators reflect each row's expansion state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100