iceboundrock / iceboundrock/AutoForge
Minor hygiene: lock file PID growth, unknown state keys, duplicated REQUIRED_PROFILES
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 8h 56m
- Merged PRs (30d)
- 40
Description
Follow-up from PR #1 review round 1, observation O6. Three small, independent cleanups:
- Lock file appends a PID per acquire without truncating. Truncate before writing the PID so the file never grows across runs.
state.from_dictsilently drops unknown keys. A typo'd optional field is lost on next save. Either fail loudly on unknown keys (consistent with "corrupt state must fail loudly") or preserve them round-trip; failing loudly is preferred.REQUIRED_PROFILESis duplicated insrc/autoforge/engine.pyandsrc/autoforge/doctor.py. Define it once (e.g. inprofiles.pynext to routing) and import it in both places.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the lock-file acquisition code, state.from_dict, and the REQUIRED_PROFILES definitions in src/autoforge/engine.py and src/autoforge/doctor.py. Make the lock file truncate before writing, make unknown state keys fail loudly, and centralize REQUIRED_PROFILES so both modules import it from one location. Confirm the existing test suite covers the resulting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100