iceboundrock / iceboundrock/AutoForge

[AF-DOC-001] README and docstrings overstate current guarantees

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

documentation
Dominant language
Python
Stars
0
Forks
0
Avg merge
8h 56m
Merged PRs (30d)
40

Description

Severity: LOW · Area: documentation

Problem

Several statements overstate current guarantees:

  • README.md: "corrupted state is never silently overwritten" — contradicted by run behaviour (#11).
  • README.md / transitions.py docstring: "all transition logic lives in transitions.py" — the engine decides in _verify_and_apply; decide_next_phase is dead (#2).
  • README.md: "every claim is verified" — MERGE / UPDATE_EPIC are unverified (#3, #13).
  • state.py from_dict comment says "ignore nothing" while the code drops unknown keys (#7 item 2).

README does correctly state that MERGE / UPDATE_EPIC are "not exercised" in this milestone.

Recommended fix

Either fix the code first and keep the sentences, or amend the sentences now to describe the milestone accurately. Close this once each referenced issue lands or the text is corrected.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the four statements in README.md, then inspect the transitions.py docstring and state.py from_dict comment alongside issues #2, #3, #7, #11, and #13. Confirm which guarantees the current milestone supports. Done means each statement is corrected to match current behavior, or the referenced implementation issues have landed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.