iceboundrock / iceboundrock/AutoForge
Wire in or remove decide_next_phase (dead transition logic)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 0
- Forks
- 0
- Avg merge
- 8h 56m
- Merged PRs (30d)
- 40
Description
Follow-up from PR #1 review round 1, observation O1.
decide_next_phase in src/autoforge/transitions.py is never called by the engine — the live phase decisions are made in engine._verify_and_apply. README states "Transition logic lives only in transitions.py", so there are now two sources of truth that already diverge:
decide_next_phasehas noREVIEW -> REVIEWstale-review edge- its
MERGEhandling differs from the engine's
Resolution options
- Make
_verify_and_applycalldecide_next_phase(single decision function, engine only verifies + applies), or - Delete
decide_next_phaseand its tests, and fix the README wording.
Option 1 is preferred so that validate_transition + decision logic remain centrally testable per AGENTS.md ("Keep transition rules centralized and testable").
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read AGENTS.md, then compare src/autoforge/transitions.py with engine._verify_and_apply, focusing on the differing REVIEW and MERGE behavior. Run the existing transition tests before changing anything. Done means there is one authoritative, tested transition decision path and the README accurately describes it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100