iamshaunjp / iamshaunjp/responsive-css-grid-build

Font no longer works after lesson-5

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
140
Forks
130
PR merge metrics
No merged PRs in 30d

Description

I noticed that when I switch to branch level-6 the font no longer works. I checked the differences and you seem to have changed the format from "truetype" to "tff" which is not a valid format. "truetype" is correct. Also, the ending semicolon is changed to a comma which breaks it. So after level 5, line 50 of style.css becomes

` src: url("assets/fonts/Rubik-Regular.ttf") format("ttf"),`

when it needs to stay

` src: url("assets/fonts/Rubik-Regular.ttf") format("truetype");`

I submitted pull requests fixing the affected branches.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with line 50 of style.css on the level-6 and affected branches, comparing the font declaration with the issue's expected values. Done means the Rubik font uses format("truetype") and ends with a semicolon, and the font works after lesson 5.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.