iamshaunjp / iamshaunjp/angular-2-playlist
Bug in http://thenetninja.co.uk/courses/angular-2-tutorials#16.Routing
- Dominant language
- CSS
- Stars
- 37
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Description
Dear super Ninja.
I am Nguyen, a software developer from Vietnam. I have been watching your videos for a month & I have to say they have really really high quality. I appreciate your effort a lot, indeed.
Just want to help you improve your tutorial, I found a tiny bug in the video http://thenetninja.co.uk/courses/angular-2-tutorials - #16.Routing. After following 100% of your instruction, my app does not work as expected. I think the problem is because **Angular** has been evolving so fast so its has changed something in the route configuration. So I went to https://angular.io/docs/ts/latest/guide/router.html, read the article, changed the code a little bit and then it ran smoothly.
You can find my commit here: https://github.com/anhvurz90/angular2Netninja/commit/ed1f5ba2c1547e3bc04510c8c20f9d16361525df.
So when you have free time please update your Angular2 Routing tutorial.
- In your tutorial#17 - Adding Links, the **routerLink** syntax should be updated also:
>
>
->>
>
>
You have been doing very well. I just help you a little bit to make your work more perfect :)
Regards,
Vu Nguyen.
p/s: I don't know how to contact you. I could not find your email so have to inform you via this channel.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.