iamkun / iamkun/dayjs

Incorrect time separator for ms and ms-my locales

Open Beginner friendly
#3,139 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
The time separator in ms and ms-my locales is `.` instead of being `:`.

**Expected behavior**
12:34 pm instead of 12.34pm

**Information**
- Day.js Version [v1.11.20]
- OS: [MacOS]
- Browser [Chrome 147]
- Time zone: [EST]

Contributor guide

Open the contributing guide

Research direction

Locate the locale definitions and time-formatting path for the ms and ms-my locales. Reproduce the reported output and compare it with the expected `12:34 pm` format. Done means both locales use a colon as the time separator, with tests covering the corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
localization
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.