iamkun / iamkun/dayjs

Wrong ms conversion

Open
#2,769 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

Getting issue with parse datetime
created small unit test to show the issue

```javascript
const ds = '2024-11-18T02:04:48.19';
expect(dayjs(ds).valueOf()).toEqual(new Date(ds).valueOf());
// error: Expected 1731913488019 to equal 1731913488190.
```

Contributor guide

Open the contributing guide

Research direction

Start with the supplied unit test and the Day.js parsing path for the timestamp `2024-11-18T02:04:48.19`; compare its millisecond handling with native `Date`. Done means the test passes and `dayjs(ds).valueOf()` matches `new Date(ds).valueOf()` for this case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.