iamkun / iamkun/dayjs

add(Duration) or subtract(Duration) in version v1.11.9 is invalid.

Open
#2,425 2 comments 4 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

```
import dayjs from "dayjs";
import duration from "dayjs/plugin/duration";

dayjs.extend(duration);

let time = dayjs();
const du = dayjs.duration({ milliseconds: 123 });
time = time.add(du);
console.log(time); //<-- Invalid Date !!!!!!!!!
```

`time.add(dayjs.duration({ milliseconds: 123 }))` in version v1.11.9 does not work, and it works normally in version v1.11.8

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.