iamkun / iamkun/dayjs

dayjs.max(dayjs('2018-01-01')) ===null?

Open
#2,306 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

I think dayjs.max(dayjs('2018-01-01')) shoulde tobe dayjs('2018-01-01') instead of null

![Snipaste_2023-05-11_18-34-10](https://github.com/iamkun/dayjs/assets/40647432/8f75b57f-b811-4049-8708-d781ad156106)

Contributor guide

Open the contributing guide

Research direction

Reproduce the reported dayjs.max(dayjs('2018-01-01')) behavior and inspect the max API entry point and its existing tests. Done means the single-date call returns the supplied Day.js value instead of null, with the behavior covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.