iamkun / iamkun/dayjs

timezone Minute is Wrong

Open
#2,130 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

console.log(moment.tz('1900-01-01 16:12:00', 'Etc/GMT+11').minute()) // 16
console.log(dayjs.tz('1900-01-01 16:12:00', 'Etc/GMT+11').minute()); // 17

why minute is wrong? @BePo65 @iamkun

**Information**
- Day.js Version [1.11.6]
- OS: [e.g. iOS]
- Browser [e.g. chrome 62]
- Time zone: [e.g. GMT-07:00 DST (Pacific Daylight Time)]

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the two timezone examples from the issue with Day.js 1.11.6 and compare the minute values against Moment. Trace the timezone handling used for the historical Etc/GMT+11 date; done means the behavior is explained and corrected or documented with a regression test, though no file or test path is named.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.