Ordinal formatting in Korean
- Dominant language
- JavaScript
- Stars
- 48.7k
- Forks
- 2.5k
- PR merge metrics
- No merged PRs in 30d
Description
**Describe the bug**
When using the format for ordinal number (```Do```) in Korean the formatting not work as expected.
**Expected behavior**
```> dayjs('2022-04-23').locale('ko').format('Do')```
For above code, output should be '23일' but currently it gives '23' instead.
I think [this line](https://github.com/iamkun/dayjs/blob/8757477601d0a6fe4d90211a9b5a821043f3ae91/src/locale/ko.js#L11) should be ``` ordinal: n => `${n}일` ```.
**Information**
- Day.js Version ordinal: 1.11.1,
- OS: Windows10
- Browser Chrome 100
- Time zone: GMT+9 No DST
Thank you
Contributor guide
Research direction
Start at src/locale/ko.js, especially the ordinal entry around line 11, and reproduce the issue with dayjs('2022-04-23').locale('ko').format('Do'). Done means the Korean locale produces the expected '23일' output instead of '23'.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- localization
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100