iamkun / iamkun/dayjs

weekOfYear 'week' method doesn't seems to handle week number 53 for 'nb' locale

Open
#1,477 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.8k
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Similar to the issue mentioned in #956, with a dutch locale (nl), the week number on the end of the year is incorrect.
Similar to the issue mentioned in #1030, with a dutch locale (fr), the week number on the end of the year is incorrect.

**Expected behavior**
When selecting the 'nb' locale and trying to return the weeknumber via days('2020-12-31').week(), the number returned is 1, while dutch calenders are supposed to return 53.

**Information**
Day.js Version: [v1.10.4]
OS: [MacOS]
Browser [Chrome 90]
Time zone: [CEST]

Contributor guide

Open the contributing guide

Research direction

Start at the weekOfYear `week()` entry point and reproduce the `days('2020-12-31').week()` case with the `nb` locale. Compare the returned value with the reported expected value of 53, and consider the issue complete when the locale handles week 53 correctly without regressing related week-number behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.