iamkun / iamkun/dayjs

Parsing meridiem characters in strings doesn't work.

Open
#1,373 2 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
48.7k
Forks
2.5k
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
I have a runkit example here: https://runkit.com/zdfs/dayjs-parse-meridiem

When parsing strings with meridiem characters, even in strict mode, meridiem characters don't affect what hour the `dayjs` object creates.

**Expected behavior**
Meridiem for KO from locale `meridiem: (hour) => (hour < 12 ? '오전' : '오후')`

In my runkit example, `const test = dayjs('2019/9/2 오후 3:30:00', 'YYYY/M/D A h:mm:ss', "ko", true);` should create a time object in the afternoon, not in the morning.

**Information**
- Day.js Version: v1.10.4
- OS: Mac Big Sur
- Browser: Chrome 87.0.4280.141
- Time zone: GMT-07:00 DST (Pacific Daylight Time)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.