iLPdev / iLPdev/discMapper

Obsolete functions or functions that can be simplified.

Open
#130 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Lua
Stars
8
Forks
5
PR merge metrics
No merged PRs in 30d

Description

Merge Rooms : No longer necessary, since the hash from gmcp.room.info positively identifies a room, no need to merge rooms, since different rooms will have different hashes and thus different room ID's.

function set_room : At the end of this functions, an onMoveMap event is raised... yet you have no handler to handle the event. Is this an event handled by the mapper that I haven't found?

function check_room(...) : Since rooms are positively identified by a hash, why do you check against room name and exits? Big issue I have with this, is that some rooms have exits that are not obvious. Once I use said exit, the exit is created, and thus this function no longer identifies a perfectly valid room and won't show you being in that room.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Merge Rooms, set_room, and check_room functions, then search for handlers or references to the onMoveMap event. Verify how gmcp.room.info hashes identify rooms and how exits are represented; done means obsolete merging and checks are removed or simplified without preventing valid rooms from being recognized.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.