iFixit / iFixit/pulldasher

Support Github Reviews

Open
#88 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
37
Forks
10
Avg merge
5d 4m
Merged PRs (30d)
1

Description

Problem:

Github reviews are a nice, but the approve or disapprove is not supported as a block or a CR.

Do this:
  • Make an approve count as a CR.
  • make request changes count as a dev_block.

Before this can happen, the api wrapper needs to be updated to a version that supports reviews.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the GitHub API wrapper and the code that classifies pull-request reviews. Update the wrapper to a version supporting reviews, then verify that approvals count as CRs and requested changes count as dev_blocks.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, typescript
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.