Treat users who `dev_block` a pull as being subscribed to that pull (as if they'd CRed it)
Open
@danielbeardsley is already working on this.
Since May 19, 2023.
- Dominant language
- TypeScript
- Stars
- 37
- Forks
- 10
- Avg merge
- 5d 4m
- Merged PRs (30d)
- 1
Description
As a developer
I want to have dev_block treated as a review
So that I notice when it gets un_dev_blocked.
Sometimes when we review a pull, it's not ready to ship. Rather than marking it as approved (with CR), we need to dev_block it for further work. When we do that, we want that pull to show up as having an out-of-date CR when it gets un_deploy_blocked, so that we can re-CR (and hopefully approve it). This also avoids looking at pulls which have another dev already involved in CRing if we don't want to.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.