APCu: fix return value of setMultiple()
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 23
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
Problem
Backend::setMultiple() has a bool return type, but the child class's implementation, APCu::setMultiple(), returns an array. We should address the inconsistency.
Background
https://github.com/iFixit/Matryoshka/blob/master/library/iFixit/Matryoshka/Backend.php#L37
https://github.com/iFixit/Matryoshka/blob/master/library/iFixit/Matryoshka/APCu.php#L16
https://www.php.net/manual/en/function.apcu-store.php#refsect1-function.apcu-store-returnvalues
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare Backend::setMultiple() in library/iFixit/Matryoshka/Backend.php with APCu::setMultiple() in library/iFixit/Matryoshka/APCu.php. Read the referenced APCu documentation to confirm the expected return values, then make the implementations consistent and verify that the child method matches the declared contract.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100