Support copying subtitles
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 131
- PR merge metrics
- No merged PRs in 30d
Description
I think a great and easy change would be to support copying existing subtitles from the original video file to the resulting interpolated one.
I'm pretty sure this can be done by simply adding -c:s copy to line 31 and line 40 of inference_video.py, though I didn't want to make a pull request in case you would want to add additional checks in case subtitle copying failed for some reason. For example, not all container formats support embedded subtitles, though I know mkv does, and possibly mp4?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect inference_video.py at lines 31 and 40, starting with how the output video is assembled. Verify subtitle retention for supported containers, especially MKV and possibly MP4, and confirm the resulting interpolated file preserves the original subtitles without breaking unsupported formats.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100