hypothesis / hypothesis/via

Loading bar color clashes on Checkmate malicious blocked pages

Open
#502 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
29
Forks
13
PR merge metrics
No merged PRs in 30d

Description

When a page is blocked because Checkmate thinks it's malicious the color of the loading bar is very similar to the background color of the page. Example:

https://via.hypothes.is/https://example.com/malicious

Slack thread: https://hypothes-is.slack.com/archives/C1M8NH76X/p1621360348014500

See also: [Loading bar doesn't finish on Checkmate pages](https://github.com/hypothesis/via/issues/501)

## Suggestions

### Just use a different color

As long as the loading bar doesn't dynamically adapt its color it's always going to clash with some pages. But we should choose a color that doesn't clash with our own pages. Blue or purple are common loading bar colors.

### Dynamically change the color

Pick two very different colors, say red and blue. Use a red loading bar by default. Detect the background color of the page and, if it's too similar to the red (color comparison algorithm required) then swap to the blue instead.

If our two color choices are far enough apart then a site can't be overly similar to both at once.

May require the loading bar to actually _change_ color mid-load, when the website's background color appears.

### Other ideas?

I think there might be better ways to dynamically adjust a loading bar's color based on the color behind it.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.